perf: avoiding use of Object.defineProperty in Chunk constructor #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described here https://humanwhocodes.com/blog/2015/11/performance-implication-object-defineproperty/
Object.defineProperty
does add some overhead.This can become significant when a lot of splitting is involved.
This PR restrict the usage of
Object.defineProperty
in DEBUG only.A benchmark using overwrite has been added, an show significant improvement.
other benchmarks have been improved too.
before
after