Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: add export to package.json, test with strict mode and node16 resolution #19

Merged

Conversation

ChristianMurphy
Copy link
Contributor

@ChristianMurphy ChristianMurphy commented Jan 3, 2023

hold off on merging this for a bit, it may require a change to is-reference first

updates upstream PRs have been merged.

This PR

  • adds type exports to package.json
  • runs typescript in strict mode
  • resolves modules in typescript in node16 (esm) mode
  • moves @types/estree to dependencies for typescript users
  • updates @types/estree to version 1.x
  • test compatibility with acorn version 8

@ChristianMurphy
Copy link
Contributor Author

opened Rich-Harris/is-reference#14 for is-reference update

@ChristianMurphy
Copy link
Contributor Author

This may also require an update to estree-walker, WIP PR started here: Rich-Harris/estree-walker#34

@ChristianMurphy
Copy link
Contributor Author

Upstream PRs have been merged.
Tests and type checks are passing.

This is ready for review when folks have a moment.
/cc @Rich-Harris @wooorm @remcohaszing

@ChristianMurphy
Copy link
Contributor Author

@Rich-Harris friendly ping.
Anything I could do to help get this across the finish line?

@Rich-Harris Rich-Harris merged commit 14eb54c into Rich-Harris:master Jan 25, 2023
@ChristianMurphy ChristianMurphy deleted the type/node-16-esm-types branch January 25, 2023 19:43
@Rich-Harris
Copy link
Owner

done, thank you! released 3.1.0

@ChristianMurphy
Copy link
Contributor Author

Thanks @Rich-Harris! 🙇

@ChristianMurphy
Copy link
Contributor Author

ChristianMurphy commented Jan 25, 2023

@Rich-Harris quick question while this is top of mind, was this pushed to npmjs.com?
I'm checking

npm view periscopic

and it is still listing version 3.0.4 as the latest version

@ChristianMurphy
Copy link
Contributor Author

I think something went wrong with the release, npm is still showing 3.0.4 as latest today, no 3.1.0 is appearing yet.

@Rich-Harris
Copy link
Owner

that's weird, could have sworn it went through. looks to be fixed now

@ChristianMurphy
Copy link
Contributor Author

Thanks, I can see the new version now 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants