Skip to content

Upgrade to NUKE 8.1 #281

Upgrade to NUKE 8.1

Upgrade to NUKE 8.1 #281

Triggered via pull request September 10, 2024 04:40
Status Success
Total duration 4m 46s
Artifacts

pr.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

20 warnings
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(18,47): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(21,48): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(25,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.StructTests.Should_have_a_shared_struct_schema() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/RecordTests.cs(14,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.RecordTests.Should_have_only_one_property() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/RecordTests.cs(23,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(34,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(73,23): warning CS8618: Non-nullable property 'Person' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(75,24): warning CS8618: Non-nullable property 'Teacher' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(77,34): warning CS8618: Non-nullable property 'WritingInstrument' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(68,23): warning CS8618: Non-nullable property 'Baz' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(18,47): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(21,48): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(25,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.StructTests.Should_have_a_shared_struct_schema() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(34,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\RecordTests.cs(14,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.RecordTests.Should_have_only_one_property() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\RecordTests.cs(23,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Converters\JsonExceptionConverterTests.cs(26,23): warning CA1507: Use nameof in place of string literal 'CompanyKey' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1507) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Generation\ArrayGenerationTests.cs(36,52): warning CA1825: Avoid unnecessary zero-length array allocations. Use Array.Empty<string>() instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1825) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Generation\AttributeGenerationTests.cs(230,22): warning CA1711: Rename type name ClassWithDictionary so that it does not end in 'Dictionary' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Generation\EnumTests.cs(54,22): warning CA1711: Rename type name ContainerWithEnumDictionary so that it does not end in 'Dictionary' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]