Skip to content

Allow attribute annotations to be on a separate line #253

Allow attribute annotations to be on a separate line

Allow attribute annotations to be on a separate line #253

Status Failure
Total duration 5m 3s
Artifacts

pr.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

20 errors and 22 warnings
ubuntu-latest
[xUnit.net 00:00:00.79] NJsonSchema.CodeGeneration.Tests.CSharp.AllOfTests.When_more_properties_are_defined_in_allOf_and_type_none_then_all_of_contains_all_properties_in_generated_code [FAIL]
ubuntu-latest
[xUnit.net 00:00:00.97] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_number_property_has_minimum_and_maximum_that_are_double_then_range_attribute_is_rendered_in_Swagger_mode [FAIL]
ubuntu-latest
[xUnit.net 00:00:00.98] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_number_property_has_minimum_and_maximum_with_exclusive_true_and_multipleof_then_range_attribute_is_rendered_in_Swagger_mode [FAIL]
ubuntu-latest
[xUnit.net 00:00:00.98] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_int32_property_has_minimum_then_range_attribute_is_rendered_in_Swagger_mode [FAIL]
ubuntu-latest
[xUnit.net 00:00:00.98] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_array_property_has_maxitems_then_maxlength_attribute_is_rendered_in_Swagger_mode [FAIL]
ubuntu-latest
[xUnit.net 00:00:00.98] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_int64_property_has_minimum_then_range_attribute_is_rendered_in_Swagger_mode [FAIL]
ubuntu-latest
[xUnit.net 00:00:00.99] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_integer_property_has_minimum_and_maximum_with_exclusive_true_then_range_attribute_is_rendered_in_Swagger_mode [FAIL]
ubuntu-latest
[xUnit.net 00:00:00.99] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_int_property_has_maximum_then_range_attribute_is_rendered_in_Swagger_mode [FAIL]
ubuntu-latest
[xUnit.net 00:00:00.99] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_string_property_has_minlength_then_stringlength_attribute_is_rendered_in_Swagger_mode [FAIL]
ubuntu-latest
[xUnit.net 00:00:01.00] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_string_property_has_maxlength_then_stringlength_attribute_is_rendered_in_Swagger_mode [FAIL]
windows-latest
[xUnit.net 00:00:00.91] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_number_property_has_minimum_and_maximum_that_are_double_then_range_attribute_is_rendered_in_Swagger_mode [FAIL]
windows-latest
[xUnit.net 00:00:00.94] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_number_property_has_minimum_and_maximum_with_exclusive_true_and_multipleof_then_range_attribute_is_rendered_in_Swagger_mode [FAIL]
windows-latest
[xUnit.net 00:00:00.94] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_int32_property_has_minimum_then_range_attribute_is_rendered_in_Swagger_mode [FAIL]
windows-latest
[xUnit.net 00:00:00.95] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_array_property_has_maxitems_then_maxlength_attribute_is_rendered_in_Swagger_mode [FAIL]
windows-latest
[xUnit.net 00:00:00.95] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_int64_property_has_minimum_then_range_attribute_is_rendered_in_Swagger_mode [FAIL]
windows-latest
[xUnit.net 00:00:00.95] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_integer_property_has_minimum_and_maximum_with_exclusive_true_then_range_attribute_is_rendered_in_Swagger_mode [FAIL]
windows-latest
[xUnit.net 00:00:00.95] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_int_property_has_maximum_then_range_attribute_is_rendered_in_Swagger_mode [FAIL]
windows-latest
[xUnit.net 00:00:00.96] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_string_property_has_minlength_then_stringlength_attribute_is_rendered_in_Swagger_mode [FAIL]
windows-latest
[xUnit.net 00:00:00.96] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_string_property_has_maxlength_then_stringlength_attribute_is_rendered_in_Swagger_mode [FAIL]
windows-latest
[xUnit.net 00:00:00.96] NJsonSchema.CodeGeneration.CSharp.Tests.ValidationAttributesTests.When_integer_property_has_minimum_and_maximum_that_are_int64_then_range_attribute_is_rendered_in_Swagger_mode [FAIL]
ubuntu-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(73,23): warning CS8618: Non-nullable property 'Person' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(75,24): warning CS8618: Non-nullable property 'Teacher' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(77,34): warning CS8618: Non-nullable property 'WritingInstrument' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(68,23): warning CS8618: Non-nullable property 'Baz' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(57,23): warning CS8618: Non-nullable property 'Bar' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(52,23): warning CS8618: Non-nullable property 'Foo' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(47,23): warning CS8618: Non-nullable property 'Baz' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(41,23): warning CS8618: Non-nullable property 'Bar' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(35,23): warning CS8618: Non-nullable property 'Foo' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/Generation/StructTests.cs(18,47): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.NewtonsoftJson.Tests/NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net8.0]
windows-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\References\YamlReferencesTests.cs(21,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_schema_has_references_it_works(string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\NJsonSchema.Yaml.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\References\YamlReferencesTests.cs(38,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_has_external_schema_refs_they_are_resolved(string, string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\NJsonSchema.Yaml.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\References\YamlReferencesTests.cs(69,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_is__served_with_gzip_compression__it_works(string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\NJsonSchema.Yaml.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\References\YamlReferencesTests.cs(83,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_has_relative_external_schema_refs_in_subdirs__they_are_resolved(string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\NJsonSchema.Yaml.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\References\YamlReferencesTests.cs(115,24): warning CA1822: Member 'GetTestDirectory' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Yaml.Tests\NJsonSchema.Yaml.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(21,48): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(18,47): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(25,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.StructTests.Should_have_a_shared_struct_schema() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(34,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\RecordTests.cs(14,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.RecordTests.Should_have_only_one_property() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]