Skip to content

feat: option to use c# 11 required keyword for required properties #255

feat: option to use c# 11 required keyword for required properties

feat: option to use c# 11 required keyword for required properties #255

Re-run triggered June 30, 2024 18:48
Status Success
Total duration 4m 43s
Artifacts

pr.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

22 warnings
ubuntu-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(21,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_schema_has_references_it_works(string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(38,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_has_external_schema_refs_they_are_resolved(string, string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(69,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_is__served_with_gzip_compression__it_works(string, string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(83,27): warning CA1707: Remove the underscores from member name NJsonSchema.Yaml.Tests.References.LocalReferencesTests.When_yaml_OpenAPI_spec_has_relative_external_schema_refs_in_subdirs__they_are_resolved(string) (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/References/YamlReferencesTests.cs(115,24): warning CA1822: Member 'GetTestDirectory' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822) [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Yaml.Tests/NJsonSchema.Yaml.Tests.csproj::TargetFramework=net8.0]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(35,23): warning CS8618: Non-nullable property 'Foo' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(73,23): warning CS8618: Non-nullable property 'Person' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(75,24): warning CS8618: Non-nullable property 'Teacher' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(77,34): warning CS8618: Non-nullable property 'WritingInstrument' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
ubuntu-latest
/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/Program.cs(41,23): warning CS8618: Non-nullable property 'Bar' must contain a non-null value when exiting constructor. Consider declaring the property as nullable. [/home/runner/work/NJsonSchema/NJsonSchema/src/NJsonSchema.Demo.Performance/NJsonSchema.Demo.Performance.csproj]
windows-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(18,47): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(21,48): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(25,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.StructTests.Should_have_a_shared_struct_schema() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\RecordTests.cs(14,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.RecordTests.Should_have_only_one_property() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\RecordTests.cs(23,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(34,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Converters\JsonExceptionConverterTests.cs(26,23): warning CA1507: Use nameof in place of string literal 'CompanyKey' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1507) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Generation\EnumTests.cs(54,22): warning CA1711: Rename type name ContainerWithEnumDictionary so that it does not end in 'Dictionary' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Generation\EnumTests.cs(72,21): warning CA1711: Rename type name MyEnum so that it does not end in 'Enum' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]
windows-latest
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Generation\EnumTests.cs(106,21): warning CA1711: Rename type name EnumWithFlags so that it does not end in 'Flags' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]