Upgrade to NUKE 8 (#1669) #163
Annotations
12 warnings
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "artifacts".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, actions/upload-artifact@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(21,48): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
|
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(18,47): warning CA1051: Do not declare visible instance fields (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1051) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
|
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(25,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.StructTests.Should_have_a_shared_struct_schema() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
|
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\RecordTests.cs(14,21): warning CA1707: Remove the underscores from member name NJsonSchema.NewtonsoftJson.Tests.Generation.RecordTests.Should_have_only_one_property() (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
|
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\StructTests.cs(34,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
|
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\Generation\RecordTests.cs(23,13): warning xUnit2013: Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.NewtonsoftJson.Tests\NJsonSchema.NewtonsoftJson.Tests.csproj::TargetFramework=net462]
|
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Converters\JsonExceptionConverterTests.cs(26,23): warning CA1507: Use nameof in place of string literal 'CompanyKey' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1507) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]
|
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Generation\ArrayGenerationTests.cs(36,52): warning CA1825: Avoid unnecessary zero-length array allocations. Use Array.Empty<string>() instead. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1825) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]
|
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Generation\AttributeGenerationTests.cs(230,22): warning CA1711: Rename type name ClassWithDictionary so that it does not end in 'Dictionary' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]
|
D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\Generation\EnumTests.cs(54,22): warning CA1711: Rename type name ContainerWithEnumDictionary so that it does not end in 'Dictionary' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1711) [D:\a\NJsonSchema\NJsonSchema\src\NJsonSchema.Tests\NJsonSchema.Tests.csproj::TargetFramework=net462]
|
This job succeeded
Loading