AdditionalProperties is generated both as bool and Dictionary

[AnderssonPeter]

Hi when generating classes for this schema it generates the class Andelisamfallighet with the following

    [System.CodeDom.Compiler.GeneratedCode("NJsonSchema", "10.6.2.0 (Newtonsoft.Json v9.0.0.0)")]

    public partial record Andelisamfallighet
    {

        [System.Text.Json.Serialization.JsonPropertyName("title")]
        public string Title { get; set; } = default!;


        [System.Text.Json.Serialization.JsonPropertyName("type")]
        public string Type { get; set; } = default!;


        [System.Text.Json.Serialization.JsonPropertyName("properties")]
        public Anonymous81 Properties { get; set; } = default!;


        [System.Text.Json.Serialization.JsonPropertyName("not")]
        public Geometrirequest Not { get; set; } = default!;


        [System.Text.Json.Serialization.JsonPropertyName("additionalProperties")]
        public bool AdditionalProperties { get; set; } = default!;



        private System.Collections.Generic.IDictionary<string, object> _additionalProperties = new System.Collections.Generic.Dictionary<string, object>();

        [System.Text.Json.Serialization.JsonExtensionData]
        public System.Collections.Generic.IDictionary<string, object> AdditionalProperties
        {
            get { return _additionalProperties; }
            set { _additionalProperties = value; }
        }

    }

And using the following settings:

{
        Namespace = @namespace,
        ClassStyle = CSharpClassStyle.Poco,
        JsonLibrary = CSharpJsonLibrary.SystemTextJson,
        GenerateNativeRecords = true,
        GenerateNullableReferenceTypes = true,
    }

As you can see AdditionalProperties is generated twice, and this causes a compilation error.

Is the schema invalid or does the generator do something invalid?

[RicoSuter]

Looks strange, it's treating schema properties as actual model properties.. I think the schema is wrong... but needs investigation.

[AnderssonPeter]

I'm not that familiar with json schemas but using https://jsonschemalint.com/#!/version/draft-07/markup/json it validates if i change from $schema to schema, could that be the source of the issue?

[AnderssonPeter]

Changing from $schema to schema didn't change anything.

[RicoSuter]

could that be the source of the issue?

NJsonSchema does not really care for the content of the "schema" property.

[AnderssonPeter]

If you tell me when you build a new nuget package, ill verify that it works as intended.

Thanks for the fast fix!!

[RicoSuter]

Not sure this is actually the fix, but this was another problem with this schema...
You can try with the preview nuget feed (v11 preview) https://www.myget.org/feed/Packages/njsonschema

[AnderssonPeter]

I have no idea how to use myget, I tried to add <add key="NJsonSchema MyGet" value="https://www.myget.org/F/njsonschema/api/v3/index.json" /> to my nuget.config, but I find no packages in that feed.

[AnderssonPeter]

Checked out the repo and changed branch to patches/fix-toolchain-version-output and tried it that way, but as you said it didn't resolve the issue.

One small question how do I use a JsonInheritanceConverter when generating code, I'm guessing that my output would be better if it would use the field/property Type and typ as discriminator..

[AnderssonPeter]

Found #13 guessing that without that implemented the output of this schema will always be subpar.