Array of nullable items are now automatically detected #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to use [ItemsCanBeNull] in an NRT context. Fixes RicoSuter/Namotion.Reflection#36
jeremyVignelles
commented
Dec 27, 2020
jeremyVignelles
force-pushed
the
fix/array-of-nullables
branch
from
7768cbe
to
dc96f02
Compare
|
Not sure why the CI failed, works on my machine... |
…tomatically-detected
jeremyVignelles
commented
Feb 4, 2021
|
I have the feeling it's because we are using 2.2 SDK and maybe this stuff produces different/better/correct NRT attributes with 5.0 SDK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to use [ItemsCanBeNull] in an NRT context.
Fixes RicoSuter/Namotion.Reflection#36