Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DisplayAttribute methods when getting name and description #1313

Merged
merged 3 commits into from
Feb 13, 2021
Merged

Use DisplayAttribute methods when getting name and description #1313

merged 3 commits into from
Feb 13, 2021

Commits on Feb 12, 2021

  1. Use DisplayAttribute methods when getting name and description 

    `DisplayAttribute` has `GetName` and `GetDescription` methods that will return the `Name` and `Description` property values respectively if no `ResourceType` has been specified on the attribute, or will look up resource values if a `ResourceType` has been specified.

This commit updates schema generation to use the above methods when a `DisplayAttribute` is used.
    @wazzamatazz
    wazzamatazz committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    04b10ec View commit details
    Browse the repository at this point in the history

  2. Check for null before calling DisplayAttribute methods 

    Only call DisplayAttribute's GetName() and GetDescription() methods if the respective Name and Description properties are non-null.
    @wazzamatazz
    wazzamatazz committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    b1da211 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2021

  1. Get name/description and then assign if not null 

    Updated as per #1313 (comment)
    @wazzamatazz
    wazzamatazz committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    3aa50c8 View commit details
    Browse the repository at this point in the history