Issue in generation of C# classes with inheritance fixed #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 17, 2021 16:14
… definitions in other files.
…hen the definitions reference the root schema. When the passed schema is already the root schema the method returns immediately instead of throwing an exception. Issue in the CSharpTypeResolver for the generation of base classes without properties fixed. When classes don't contain properties but contain the "descriminator" attribute they should still be generated.
|
@RicoSuter Please can you review and merge the changes, if you agree with them. Thank you |
|
Lgtm, thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue in the
JsonSchemaAppenderfor the generation of classes fixed when the definitions reference the root schema. When the passed schema is already the root schema the method returns immediately instead of throwing an exception. In this case the definitions are already known and there is no reason to throw an exception.Issue in the
CSharpTypeResolverfor the generation of base classes without properties fixed. When classes don't contain properties but contain the "discriminator" attribute they should still be generated. Otherwise it's not possible to define a class hierarchy where the parent class does not contain any property.My assumption is that when "discriminator" is defined there is at least one derived class which is interested in this specific type, so it would be wrong to just replace it with AnyType (object)