Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix supporting System.Text.Json in CSharpJsonSerializerGenerator #1331

Merged
merged 5 commits into from
Feb 28, 2021
Merged

Fix supporting System.Text.Json in CSharpJsonSerializerGenerator #1331

merged 5 commits into from
Feb 28, 2021

Conversation

unchase
Copy link
Contributor

@unchase unchase commented Feb 27, 2021

Added the tests to CSharpJsonSerializerGeneratorTests.

@unchase
Copy link
Contributor Author

unchase commented Feb 27, 2021

@RicoSuter ready for review.

@unchase unchase mentioned this pull request Feb 27, 2021
Open
1 task
@RicoSuter
Copy link
Owner

Thanks for adding also some unit tests.. was too lazy, but it's important to avoid regressions.

@RicoSuter RicoSuter merged commit 896bbb9 into RicoSuter:master Feb 28, 2021
@RicoSuter
Copy link
Owner

Thx for the PR.

@unchase unchase deleted the fix/add-supporting-system-text-json-in-csharp-json-serializer-generator branch March 1, 2021 20:02
@unchase
Copy link
Contributor Author

unchase commented Mar 1, 2021

You are welcome!
@RicoSuter could you please to publish changes to the new release (v10.3.10) that I will use it for try to solve NSwag#2243

This was referenced Mar 8, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RicoSuter RicoSuter Awaiting requested review from RicoSuter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unchase @RicoSuter