Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add small fix to CSharpJsonSerializerGenerator #1333

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Add small fix to CSharpJsonSerializerGenerator #1333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/NJsonSchema.CodeGeneration.CSharp.Tests/CSharpJsonSerializerGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public void When_using_SytemTextJson_with_JsonConverters_GenerateJsonSerializerP
Console.WriteLine(output);

//// Assert
Assert.Equal(", System.Text.Json.JsonSerializerOptions(); var converters = new System.Text.Json.Serialization.JsonConverter[] { new CustomConverter1(), new CustomConverter2(), new AdditionalConverter1(), new AdditionalConverter2() }", output);
Assert.Equal(", new System.Text.Json.JsonSerializerOptions(); var converters = new System.Text.Json.Serialization.JsonConverter[] { new CustomConverter1(), new CustomConverter2(), new AdditionalConverter1(), new AdditionalConverter2() }", output);
}

[Fact]
Expand Down Expand Up @@ -58,7 +58,7 @@ public void When_using_SytemTextJson_with_JsonSerializerSettingsOrOptionsTransfo
Console.WriteLine(output);

//// Assert
Assert.Equal(", TestJsonSerializerSettingsTransformationMethod(System.Text.Json.JsonSerializerOptions())", output);
Assert.Equal(", TestJsonSerializerSettingsTransformationMethod(new System.Text.Json.JsonSerializerOptions())", output);
}

[Fact]
Expand Down
2 changes: 1 addition & 1 deletion src/NJsonSchema.CodeGeneration.CSharp/CSharpJsonSerializerGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ private static string GenerateForJsonLibrary(CSharpGeneratorSettings settings, L
{
return ", " +
(useSettingsTransformationMethod ? settings.JsonSerializerSettingsTransformationMethod + "(" : string.Empty) +
"System.Text.Json.JsonSerializerOptions()" +
"new System.Text.Json.JsonSerializerOptions()" +
(useSettingsTransformationMethod ? ")" : string.Empty) +
(hasJsonConverters
? "; var converters = " + GenerateConverters(jsonConverters, settings.JsonLibrary)
Expand Down