cast dictionary to any during assignment #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As you only have changes in templates, you can test your changes by simply overriding the given templates: https://github.com/RicoSuter/NJsonSchema/wiki/Templates If everything is fine we can merge the PR. Btw, the tests failed so you'd need to update/fix them as well. |
|
@RicoSuter thank you! Tested my changed via the template directory like you suggested - they're working fine now. Updated tests, they pass locally. |
|
Thanks for the PR. |
adamjones1
pushed a commit
to adamjones1/NJsonSchema
that referenced
this pull request
May 24, 2021
* patch/improved-enum-handling * Improved enum handling resolves RicoSuter#1357 * Added tests to cover operators and plus or minus characters * Update DefaultEnumNameGenerator.cs Co-authored-by: Rico Suter <mail@rsuter.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix RicoSuter/NSwag#2881 by simply casting dictionaries to any before doing assignment.
As far as I can tell, there isn't a great way to fix this outside of casting the dictionary to any. Even if the keys are properly typed, you can still run into issues with read-only values being assigned. Since this is a fully internal operation casting the dictionary to any seems safe enough.
I'm having a lot of trouble figuring out how to get this built and how to use it locally in order to test it however.