Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve LeafType generated code #1382

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Improve LeafType generated code #1382

merged 1 commit into from
Jul 1, 2021

Conversation

trejjam
Copy link
Sponsor Contributor

@trejjam trejjam commented Jun 25, 2021

The generated code using the UseLeafType was not 100% correct for arrays. This PR changes generated code from:

property: A[] | B[],

to:

property: (A | B)[],

@RicoSuter RicoSuter merged commit 82a3e89 into RicoSuter:master Jul 1, 2021
@RicoSuter
Copy link
Owner

Thanks for the PR.

@trejjam trejjam deleted the feature/leaf-type-improvements branch July 1, 2021 21:55
@trejjam trejjam mentioned this pull request Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trejjam @RicoSuter