Enable support for C# 9.0 records #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… understand C# 9.0. This requires dropping the dependency on .NET 4.52.
|
I want to call out that in order to make the unit tests work, I had to upgrade the Microsoft.CodeAnalysis.CSharp dependency from 3.8.0 to 3.11.0, which is not compatible with .NET 4.5.2. I had to remove .NET 4.5.2 as a target framework for NJsonSchema.CodeGeneration.CSharp.Tests. I think this is a reasonable thing to do since it's test code, and doesn't impact NSwag/NJsonSchema's ability to generate .NET 4.5.2 code, but I want to make sure there's no pushback. Alternately, we could just not AssertCompile() in that unit test, but I think that's a worse solution. |
RicoSuter
reviewed
Oct 8, 2021
src/NJsonSchema.CodeGeneration.CSharp/Models/ClassTemplateModel.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Apologies in advance if I should have submitted an issue or something instead of just a PR out of the blue.]
This PR, in conjunction with a separate PR to NSwag, adds an option to change how ClassStyle="Record" generates DTOs. If you set "classStyle": "Record" and also "UseNativeRecords": true, nswag will generate DTOs as records instead of classes.
This allows you to use C# 9.0 "with" statements for usability, while still maintaining null safety.