Fix race condition in GetName #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuruev
added a commit
to servicetitan/NJsonSchema
that referenced
this pull request
Nov 16, 2023
* Update README.md * Handle single quote in properties names (RicoSuter#1574) * added abstract schema checking to CSharpValueGenerator GetDefaultValue (RicoSuter#1570) Co-authored-by: Gergo Vandor <gergo.vandor.dev@outlook.com> * Recursive sample generation (RicoSuter#1561) * Add tests that show generator doesnt handle definition re-use/recursion * Allow definition re-use/recursion in SampleJsonDataGenerator Adds a MaxRecursionLevel to SampleJsonDataGeneratorSettings * Add test of recursion level * Fix race condition in GetName (RicoSuter#1571) * Update Namotion.Reflection * v11.1.0 * Revert "v11.1.0" This reverts commit 1015b01. * Post-merge adjustments --------- Co-authored-by: Rico Suter <mail@rsuter.com> Co-authored-by: kal <35899782+kalilistic@users.noreply.github.com> Co-authored-by: Gergo Vandor <vandor.gergoo@gmail.com> Co-authored-by: Gergo Vandor <gergo.vandor.dev@outlook.com> Co-authored-by: Flemming Madsen <mail@leflings.dk> Co-authored-by: SeongChan Lee <foriequal@gmail.com> Co-authored-by: Rico Suter <rico.suter@buhlergroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading a dictionary without acquiring a lock while there's a writer out there is not safe.
I couldn't use ConcurrentDictionary because it requires netstandard 1.1