Add API support for multiple schema extension definitions #1578
Conversation
|
Would appreciate a review whenever @lahma or @RicoSuter have the time. This isn't a big change but I'd be happy to hear any feedback you might have |
| namespace NJsonSchema.Annotations | ||
| { | ||
| /// <summary>Interface to add multiple extension data property to a class or property, implementation needs to inherit from System.Attribute.</summary> | ||
| public interface IMultiJsonSchemaExtensionDataAttribute |
There was a problem hiding this comment.
I'm not a subject matter expect here (Rico is), but would it make sore sense just to make a breaking change to change the support to have dictionary in original interface so there wouldn't be two ways to achieve the same thing (adding one item can be done via dictionary or via old interface).
There was a problem hiding this comment.
this definitely could be done, I took the more conservative approach because I didn't want to break existing functionality. I don't mind refactoring to do what you suggest if that's what is agreed upon
There was a problem hiding this comment.
would appreciate a review @RicoSuter when you have some time
|
v11 |
This PR enables a developer to define attributes that allow multiple schema extensions to be defined.
Fixes #1568