Optimize type resolving #1629
Merged
Optimize type resolving #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
optimize-DefaultTypeNameGenerator
branch
from
ac78ad1
to
3e2e17b
Compare
* reuse same HashSet for reservedTypeNames instead re-creating on every cache miss * cleanup csprojs * remove build configurations for _build project in solution file * use string interpolation for better optimizations
lahma
force-pushed
the
optimize-DefaultTypeNameGenerator
branch
from
3e2e17b
to
0cedbe9
Compare
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HashSetforreservedTypeNamesinstead re-creating on every cache miss_buildproject in solution file (prevents local command line usage)The test case has only 3 types and shows the difference quite nicely, real world usage can have hundreds of items, if not thousands.
NJsonSchema.Benchmark.CSharpTypeResolverBenchmark