Support configuring whether to generate StringEnumConverter

src/NJsonSchema.CodeGeneration.CSharp.Tests/EnumTests.cs

@@ -1,14 +1,17 @@
 using Newtonsoft.Json;
 using Newtonsoft.Json.Converters;
 using NJsonSchema.CodeGeneration.CSharp;
-using NJsonSchema.Generation;
 using NJsonSchema.NewtonsoftJson.Generation;
 using System.Collections.Generic;
 using System.Threading.Tasks;
+using VerifyXunit;
 using Xunit;
 
+using static NJsonSchema.CodeGeneration.CSharp.Tests.VerifyHelper;
+
 namespace NJsonSchema.CodeGeneration.Tests.CSharp
 {
+    [UsesVerify]
     public class EnumTests
     {
         [Fact]
@@ -167,6 +170,20 @@ public async Task When_enum_is_nullable_then_StringEnumConverter_is_set()
                 code);
         }
 
+        [Fact]
+        public async Task When_StringEnumConverter_is_disabled_attribute_is_not_generated()
+        {
+            //// Arrange
+            var schema = NewtonsoftJsonSchemaGenerator.FromType<MyStringEnumListTest>();
+            var generator = new CSharpGenerator(schema, new CSharpGeneratorSettings { ClassStyle = CSharpClassStyle.Poco, GenerateStringEnumConverterAttributes = false });
+
+            //// Act
+            var output = generator.GenerateFile();
+
+            //// Assert
+            await Verify(output);
+        }
+
         public enum SomeEnum
         {
             Thing1,

src/NJsonSchema.CodeGeneration.CSharp.Tests/NJsonSchema.CodeGeneration.CSharp.Tests.csproj

@@ -14,6 +14,7 @@
 
     <ItemGroup>
         <PackageReference Include="Microsoft.NET.Test.Sdk" />
+        <PackageReference Include="Verify.XUnit" />
         <PackageReference Include="xunit" />
         <PackageReference Include="xunit.runner.visualstudio" PrivateAssets="all" />
         <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Condition="'$(TargetFramework)' == 'net6.0'" />

src/NJsonSchema.CodeGeneration.CSharp.Tests/Snapshots/EnumTests.When_StringEnumConverter_is_disabled_attribute_is_not_generated.verified.txt

@@ -0,0 +1,37 @@
+//----------------------
+// <auto-generated>
+//     Generated using the NJsonSchema v11.0.0.0 (Newtonsoft.Json v13.0.0.0) (http://NJsonSchema.org)
+// </auto-generated>
+//----------------------
+
+
+namespace MyNamespace
+{
+    #pragma warning disable // Disable all warnings
+
+    [System.CodeDom.Compiler.GeneratedCode("NJsonSchema", "11.0.0.0 (Newtonsoft.Json v13.0.0.0)")]
+    public enum MyStringEnum
+    {
+
+        [System.Runtime.Serialization.EnumMember(Value = @"Foo")]
+        Foo = 0,
+
+
+        [System.Runtime.Serialization.EnumMember(Value = @"Bar")]
+        Bar = 1,
+
+
+    }
+
+    [System.CodeDom.Compiler.GeneratedCode("NJsonSchema", "11.0.0.0 (Newtonsoft.Json v13.0.0.0)")]
+    public partial class MyStringEnumListTest
+    {
+        [Newtonsoft.Json.JsonProperty("Enums", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
+        public System.Collections.Generic.ICollection<MyStringEnum> Enums { get; set; }
+
+        [Newtonsoft.Json.JsonProperty("NullableEnum", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
+        public MyStringEnum? NullableEnum { get; set; }
+
+
+    }
+}

src/NJsonSchema.CodeGeneration.CSharp.Tests/VerifyHelper.cs

@@ -0,0 +1,19 @@
+using System;
+using VerifyTests;
+using VerifyXunit;
+
+namespace NJsonSchema.CodeGeneration.CSharp.Tests;
+
+public static class VerifyHelper
+{
+    /// <summary>
+    /// Helper to run verify tests with sane defaults.
+    /// </summary>
+    public static SettingsTask Verify(string output)
+    {
+        return Verifier
+            .Verify(output)
+            .ScrubLinesContaining(StringComparison.OrdinalIgnoreCase, "Generated using the NSwag toolchain")
+            .UseDirectory("Snapshots");
+    }
+}

src/NJsonSchema.CodeGeneration.CSharp/CSharpGeneratorSettings.cs

@@ -37,6 +37,7 @@ public CSharpGeneratorSettings()
 
             RequiredPropertiesMustBeDefined = true;
             GenerateDataAnnotations = true;
+            GenerateStringEnumConverterAttributes = true;
             TypeAccessModifier = "public";
             PropertySetterAccessModifier = string.Empty;
             GenerateJsonMethods = false;
@@ -64,6 +65,9 @@ public CSharpGeneratorSettings()
         /// <summary>Gets or sets a value indicating whether to generated data annotation attributes (default: true).</summary>
         public bool GenerateDataAnnotations { get; set; }
 
+        /// <summary>Gets or sets a value indicating whether to add string to enum converter attribute for the property  (default: true).</summary>
+        public bool GenerateStringEnumConverterAttributes { get; set; }
+
         /// <summary>Gets or sets the any type (default: "object").</summary>
         public string AnyType { get; set; }
 

src/NJsonSchema.CodeGeneration.CSharp/Models/ClassTemplateModel.cs

@@ -147,6 +147,9 @@ public ClassTemplateModel(string typeName, CSharpGeneratorSettings settings,
         /// <summary>Gets a value indicating whether to use the DateFormatConverter.</summary>
         public bool UseDateFormatConverter => _settings.DateType.StartsWith("System.DateTime");
 
+        /// <summary>Gets a value indicating whether to use the DateFormatConverter.</summary>
+        public bool UseStringEnumConverter => _settings.GenerateStringEnumConverterAttributes;
+
         /// <summary>Gets or sets the access modifier of generated classes and interfaces.</summary>
         public string TypeAccessModifier => _settings.TypeAccessModifier;
 

src/NJsonSchema.CodeGeneration.CSharp/Templates/Class.liquid

@@ -60,7 +60,7 @@
     // TODO(system.text.json): Add string enum item converter
 {%-   endif -%}
 {%- else -%}
-    [Newtonsoft.Json.JsonProperty("{{ property.Name }}", Required = {{ property.JsonPropertyRequiredCode }}{% if property.IsStringEnumArray %}, ItemConverterType = typeof(Newtonsoft.Json.Converters.StringEnumConverter){% endif %})]
+    [Newtonsoft.Json.JsonProperty("{{ property.Name }}", Required = {{ property.JsonPropertyRequiredCode }}{% if property.IsStringEnumArray and UseStringEnumConverter %}, ItemConverterType = typeof(Newtonsoft.Json.Converters.StringEnumConverter){% endif %})]
 {%- endif -%}
 {%-   if property.RenderRequiredAttribute -%}
     [System.ComponentModel.DataAnnotations.Required{% if property.AllowEmptyStrings %}(AllowEmptyStrings = true){% endif %}]
@@ -80,7 +80,7 @@
 {%-   if property.RenderRegularExpressionAttribute -%}
     [System.ComponentModel.DataAnnotations.RegularExpression(@"{{ property.RegularExpressionValue }}")]
 {%-   endif -%}
-{%-   if property.IsStringEnum -%}
+{%-   if property.IsStringEnum and UseStringEnumConverter -%}
 {%-     if UseSystemTextJson -%}
     [System.Text.Json.Serialization.JsonConverter(typeof(System.Text.Json.Serialization.JsonStringEnumConverter))]
 {%-     else -%}