Fix bug that C# property not nullable when specified via reference #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @RicoSuter , is there anything I can do to get this fix into the repo? It's quite a pain to use a local version of NSwag every time to avoid this bug. |
|
Thanks for merging @RicoSuter ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that has been found using both NSwag and NJsonSchema. Essentially when
GenerateNullableReferenceTypesandGenerateOptionalPropertiesAsNullableare both true, these settings are not respected for an optional object property provided via a reference ($ref) and the resulting C# property is not optional.I believe this may solve multiple issues raised in both NSwag and NJsonSchema repos, for example:
#1305
RicoSuter/NSwag#4280 (maybe?)
I've added a test that reproduces the problem and passes with the fix.