Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# Generator: Generate range for different formats #1720

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rbergheim
Copy link

This is an attempt at generating C# Range annotations that supports more formats. My problem was that this property:

myProperty:
  type: integer
  format: int64
  minimum: 0

Generated this C# code:

[Newtonsoft.Json.JsonProperty("myProperty", Required = Newtonsoft.Json.Required.Always)]
[System.ComponentModel.DataAnnotations.Range(0D, double.MaxValue)]
public long MyProperty { get; set; }

The code was defaulting to using double values if the format was not int32. In my example it should use 0L, long.MaxValue. Now it should use the correct suffixes and the correct max values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant