Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Newtonsoft.Json dependency #4054

Closed

Conversation

bdovaz
Copy link

@bdovaz bdovaz commented Jun 21, 2022

  • Use the minimum version compatible with .NET Standard 2.0 (11.0.1)
  • Remove dependency when solving transitively

- Use the minimum version compatible with .NET Standard 2.0 (11.0.1)
- Remove dependency when solving transitively
@bdovaz
Copy link
Author

bdovaz commented Aug 31, 2022

@RicoSuter how is this going?

Not relying on at least Newtonsoft.Json version 11.0.1 exposes us to the following vulnerabilities:

https://msrc.microsoft.com/update-guide/en-US/vulnerability/CVE-2019-0820

https://access.redhat.com/errata/RHSA-2019:1259

Can you merge this PR and release a new version in NuGet?

Actually, according to NuGet's website, we are still exposed to more vulnerabilities that are only fixed in the latest version (13.0.1 as of today):

https://www.nuget.org/packages/Newtonsoft.Json/

If necessary I can change the minimum version of this PR from 11.0.1 to 13.0.1 but I didn't want to make such a "radical" change.

Edit: What I mention also affects this other PR which is also mine:

RicoSuter/NJsonSchema#1531

@bdovaz
Copy link
Author

bdovaz commented Jul 7, 2023

@RicoSuter friendly ping!

@RicoSuter
Copy link
Owner

v14 will use Newtonsoft.Json v13 and also requires at least netstd 2.0

@RicoSuter RicoSuter closed this Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants