Support NSWAG_NOLOGO and NSWAG_NOVERSION environment variables #4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
changed the title
lahma
force-pushed
the
no-version-no-logo
branch
from
459248d
to
8a646ff
Compare
lahma
force-pushed
the
no-version-no-logo
branch
from
8a646ff
to
3465b70
Compare
|
Thanks for the PR. |
lahma
added a commit
to lahma/NSwag
that referenced
this pull request
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After battling with correct regexes it dawned to me that maybe it's just easier to support specific environment variables like
NSWAG_NOLOGOandNSWAG_NOVERSION- like we haveDOTNET_NOLOGOand friends. As templates include thevprefix didn't touch that for backwards compatibility.