Apply ParameterDateFormat to date in header as well #4760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following parameter:
The generated code would be:
In this case the date is passed as a full date including the timestamp in the US format. This causes the request to be rejected.
The pull requests adds a check for
IsDate
in the same way it exists for query parameters. In addition a check forIsSystemNullable
is added. The type for the parameter generated in the function call isSystem.DateTimeOffset? x_Reference_Date
. Without the check the generated code does not generate the?.ToString(
with the null-conditional oprator causing a compile error.Technically this would be a breaking I guess?