Features/two-phase generation #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
RicoSuter
reviewed
Sep 20, 2019
| using System; | ||
| using System.Collections.Generic; | ||
|
|
||
| namespace SigSpec.Core | ||
| { | ||
| [JsonConverter(typeof(JsonReferenceConverter))] |
There was a problem hiding this comment.
Why do you remove this? I think it's needed for correct $ref handling
There was a problem hiding this comment.
I wasn't able to properly serialize and then deserialize SigSpecDocument. Deserialization always threw StackOverflowException. It looked has an infinite loop while trying to deserialize the document (commit aeeaf90 depicts the problem) . Removing the attribute solved the problem and I was able to deserialize and generate the TS client.
There was a problem hiding this comment.
If you think my solution does not work, please indicate and I revoke my PR.
|
Closing the PR as it is not accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make possible to serialize/deserialize SigSpecDocument