Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add carrier integration based on infinitive project #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jgordon165
Copy link

Provide carrier support based upon the infinitive project

https://github.com/acd/infinitive

@Riebart
Copy link
Owner

Riebart commented Nov 4, 2020

This looks like it could either be a related repo/project, or it could live in a contrib portion of this library (since those that don't use a Carrier system would have no use for this, and this code doesn't directly touch any of the Vivint logic).

Thoughts?

@jgordon165
Copy link
Author

how would you represent the "contrib" portion? Like another folder?

@Riebart
Copy link
Owner

Riebart commented Nov 4, 2020

how would you represent the "contrib" portion? Like another folder?

Yeah. Rearrange this into a proper Python module, and the Carrier stuff would life in vivint.contrib.carrier or similar, while the the main stuff would remain as vivint.PanelRoot. This has the benefit of giving semi-related stuff a nice home inside the project.

@jgordonpds
Copy link

good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants