This repository has been archived by the owner on Jul 13, 2022. It is now read-only.
Code refactor #466
Merged
Code refactor #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slyfox42
added a commit
that referenced
this pull request
Oct 5, 2018
* initial commit 🌅 * Initial Template (#450) * initial commit * added abi-gen script * wip * first tests * working constant methods * first contract tests * template cleanup * minor fix to tests * removed abis folder * removed typechain contracts * commented non working circleci steps * removed useless files * rollback RigoToken test * eslint ignoring generated files * minor rollback * fixes to package.json * Events Support (#451) * added getPastEvents method * added allEvents function * added once, missing test * modified event partial * fixed event partial * now only contracts with events extend the baseContract * fixed unit tests * fixed return types of txFunctions * removed test file, minor refactor * Fix API build process (#453) * initial commit 🌅 * minor fixes * removed unused dependencies * restored build-api circleci step * fix to package.json * minor fixes * removed extra web3 instance * fixed build script * Update DApp with new API (#454) * initial commit 🌅 * wip * wip * seems to be working * removed ganache-cli dependency from api * added contractFactory function * refactoring and fixed errors * restored build-dapp step in circleci config * fixed stuck getId on API file * refactor * Fixed DApp unit tests (#462) * updated babel and dependencies * fixed blockchainservice tests * fixed getVaultFees and getVaultSupply * fixed getVaultTransactions * fixed selectFirstVault and createVault epic * updated snapshots temporarily * fixed remaining unit tests * removed babel-preset-react-app * removed unused dependency. fixed babel dependency versions to avoid issues in the future * fixed circleCI steps * fix to babel-core version * refactored code to avoid bugs * fixed unit and feature tests * using rawgit url with cdn * fix to vaults feature test * code refactor (#466)
slyfox42
added a commit
that referenced
this pull request
Oct 5, 2018
* initial commit 🌅 * Initial Template (#450) * initial commit * added abi-gen script * wip * first tests * working constant methods * first contract tests * template cleanup * minor fix to tests * removed abis folder * removed typechain contracts * commented non working circleci steps * removed useless files * rollback RigoToken test * eslint ignoring generated files * minor rollback * fixes to package.json * Events Support (#451) * added getPastEvents method * added allEvents function * added once, missing test * modified event partial * fixed event partial * now only contracts with events extend the baseContract * fixed unit tests * fixed return types of txFunctions * removed test file, minor refactor * Fix API build process (#453) * initial commit 🌅 * minor fixes * removed unused dependencies * restored build-api circleci step * fix to package.json * minor fixes * removed extra web3 instance * fixed build script * Update DApp with new API (#454) * initial commit 🌅 * wip * wip * seems to be working * removed ganache-cli dependency from api * added contractFactory function * refactoring and fixed errors * restored build-dapp step in circleci config * fixed stuck getId on API file * refactor * Fixed DApp unit tests (#462) * updated babel and dependencies * fixed blockchainservice tests * fixed getVaultFees and getVaultSupply * fixed getVaultTransactions * fixed selectFirstVault and createVault epic * updated snapshots temporarily * fixed remaining unit tests * removed babel-preset-react-app * removed unused dependency. fixed babel dependency versions to avoid issues in the future * fixed circleCI steps * fix to babel-core version * refactored code to avoid bugs * fixed unit and feature tests * using rawgit url with cdn * fix to vaults feature test * code refactor (#466) * updated API readme
slyfox42
added a commit
that referenced
this pull request
Oct 5, 2018
* initial commit 🌅 * Initial Template (#450) * initial commit * added abi-gen script * wip * first tests * working constant methods * first contract tests * template cleanup * minor fix to tests * removed abis folder * removed typechain contracts * commented non working circleci steps * removed useless files * rollback RigoToken test * eslint ignoring generated files * minor rollback * fixes to package.json * Events Support (#451) * added getPastEvents method * added allEvents function * added once, missing test * modified event partial * fixed event partial * now only contracts with events extend the baseContract * fixed unit tests * fixed return types of txFunctions * removed test file, minor refactor * Fix API build process (#453) * initial commit 🌅 * minor fixes * removed unused dependencies * restored build-api circleci step * fix to package.json * minor fixes * removed extra web3 instance * fixed build script * Update DApp with new API (#454) * initial commit 🌅 * wip * wip * seems to be working * removed ganache-cli dependency from api * added contractFactory function * refactoring and fixed errors * restored build-dapp step in circleci config * fixed stuck getId on API file * refactor * Fixed DApp unit tests (#462) * updated babel and dependencies * fixed blockchainservice tests * fixed getVaultFees and getVaultSupply * fixed getVaultTransactions * fixed selectFirstVault and createVault epic * updated snapshots temporarily * fixed remaining unit tests * removed babel-preset-react-app * removed unused dependency. fixed babel dependency versions to avoid issues in the future * fixed circleCI steps * fix to babel-core version * refactored code to avoid bugs * fixed unit and feature tests * using rawgit url with cdn * fix to vaults feature test * code refactor (#466) * updated createVault to estimate the gas amount rather than using hardcoded one
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #442