Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added contrast on hover for problem list #33

Conversation

chirag3003
Copy link
Contributor

@chirag3003 chirag3003 commented Oct 1, 2021

closes #30

@chirag3003
Copy link
Contributor Author

chirag3003 commented Oct 1, 2021

#30
pls give this pr a label of hacktoberfest-accepted

@Rishabh-malhotraa
Copy link
Owner

Would you please add a screenshot of how the hover looks now, Thanks!

@chirag3003
Copy link
Contributor Author

Would you please add a screenshot of how the hover looks now, Thanks!

hover-screenshot

@chirag3003
Copy link
Contributor Author

@Rishabh-malhotraa when will u merge?

@Rishabh-malhotraa
Copy link
Owner

Rishabh-malhotraa commented Oct 1, 2021

@Rishabh-malhotraa when will u merge?

I'll merge it as soon as I can get time to check out the changes locally on my computer, I'm a bit busy with college assignments, I'll merge it by the end of week positively.

@chirag3003
Copy link
Contributor Author

@Rishabh-malhotraa can u check this pr cause it will only be accepted for hactoberfest when merged

@Rishabh-malhotraa
Copy link
Owner

LGTM, thank you!

@Rishabh-malhotraa Rishabh-malhotraa merged commit c1cf711 into Rishabh-malhotraa:main Oct 5, 2021
@Rishabh-malhotraa
Copy link
Owner

@all-contributors please add @chirag3003

@allcontributors
Copy link
Contributor

@Rishabh-malhotraa

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

@Rishabh-malhotraa
Copy link
Owner

@all-contributors please add @chirag3003 for design

@allcontributors
Copy link
Contributor

@Rishabh-malhotraa

I've put up a pull request to add @chirag3003! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving Contrast on hover
2 participants