Fix bug of geting destination and add new ln invoice test vector from bolt11 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return error tuple instead of crashing when decoding a ln invoice with sub msat in amount new test vectors are copied from lightning/bolts#736
leishman
reviewed
May 17, 2020
lib/lightning_network/invoice.ex
Outdated
|
|
||
| {:ok, amount_msat} | ||
| case Decimal.equal?(rounded_amount_msat_dec, amount_msat_dec) do |
There was a problem hiding this comment.
I changed it back to using D to be more consistent. Thanks!
leishman
approved these changes
May 18, 2020
…eld but it's able to recover it in signature recovery. ignore n and h field if data length is not valid
kafaichoi
force-pushed
the
add-new-ln-invoice-test-vector-from-bolt11
branch
from
fc0ae59 to
3f0334b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran test and lint in local. All passed.