Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable openssl test #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions c_src/build_deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ TARGET="$PRIV_PATH"/libsecp256k1_nif.so

case "$1" in
clean)
rm -rf secp256k1
rm -rf c_src/secp256k1
;;

*)
# skip download and compile when the compiled so is there
test -f $TARGET && exit 0
(test -d c_src/secp256k1 || git clone https://github.com/bitcoin/secp256k1)
(test -d c_src/secp256k1 || cd c_src && git clone https://github.com/bitcoin/secp256k1)

(cd c_src/secp256k1 && git reset --hard 5a91bd768faaa974e00301e662fd8f2aa75a122a && ./autogen.sh && ./configure --enable-module-recovery && make)
(cd c_src/secp256k1 && git reset --hard 5a91bd768faaa974e00301e662fd8f2aa75a122a && ./autogen.sh && ./configure --enable-openssl-tests=no --enable-module-recovery && make)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we try now to update this to the head of master (b19c000063be11018b4d1a6b0a85871ab9d0bdcf)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it @leishman but it broke quite a lot of thing. So I guess it will take some effort that's why I didn't update this in this sprint

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok got it.

#(cd secp256k1 && ./autogen.sh && ./configure --enable-module-recovery && make)
;;
esac