Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor module context provider #252

Merged
merged 7 commits into from
Mar 29, 2023

Conversation

Rllyyy
Copy link
Owner

@Rllyyy Rllyyy commented Mar 25, 2023

The old context provider contained duplicate data. Previously all the questions were saved in the context. This has been changed to only the question ids. When the question component mounts, it will read the data from the localStorage instead.

@Rllyyy Rllyyy self-assigned this Mar 25, 2023
@netlify
Copy link

netlify bot commented Mar 25, 2023

Deploy Preview for repeatio ready!

Name Link
🔨 Latest commit 66db300
🔍 Latest deploy log https://app.netlify.com/sites/repeatio/deploys/6424a13b4463bc00073fea32
😎 Deploy Preview https://deploy-preview-252--repeatio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Rllyyy
Copy link
Owner Author

Rllyyy commented Mar 25, 2023

Things that need to be done:

Test:

  • Navigate to defaults if the urlParms are incorrect or undefined on url navigation by user
  • Test what happens if the current id is not a part of the bookmarked Questions
  • Fix failing tests (Cypress and Jest)

…tion navigation not showing on mobile + Added delete tests
@Rllyyy Rllyyy linked an issue Mar 26, 2023 that may be closed by this pull request
7 tasks
Rllyyy added 2 commits March 29, 2023 20:49
…+ fixed failing tests + fixed correction not disappearing on deletion, edit and navigation
@Rllyyy Rllyyy marked this pull request as ready for review March 29, 2023 20:42
@Rllyyy Rllyyy merged commit cd21971 into release-v0.4 Mar 29, 2023
@Rllyyy Rllyyy deleted the refactor-module-context-provider branch April 4, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment