Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourse Overlay no results fix (Closes #278) #280

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

mdroidian
Copy link
Collaborator

Discourse Overlay sends results which is an array, of {label:string,results:[]} so even if it's empty it won't trigger the onRefresh() which sets setLoading(false)

!results is still useful for ReferenceContext and ResultsTable

{caretOpen && <ContextContent title={title} />}

<ContextContent uid={extraRowUid} />

@mdroidian
Copy link
Collaborator Author

mdroidian commented Sep 14, 2024

Super weird. I can't sync another commit to this one either now.

Nor can I merge it. It is stuck at Checking for ability to merge automatically…

image

https://www.githubstatus.com/ says All Systems Operational

hmm ... I'll check back later

@dvargas92495
Copy link
Collaborator

Screenshot 2024-09-14 at 6 12 52 PM

nah they struggling

@mdroidian mdroidian merged commit c71de5d into main Sep 15, 2024
1 check passed
@mdroidian mdroidian deleted the dgraph-overlay-no-results-fix branch September 15, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants