Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui update, add debug panel #100

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Conversation

mdroidian
Copy link
Collaborator

No description provided.

@mdroidian mdroidian requested a review from dvargas92495 October 1, 2023 02:02
@mdroidian mdroidian marked this pull request as ready for review October 4, 2023 03:02
Copy link
Collaborator

@dvargas92495 dvargas92495 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ after state consolidation

src/components/DailyConfigComponent.tsx Outdated Show resolved Hide resolved
src/components/DailyConfigComponent.tsx Outdated Show resolved Hide resolved
src/components/DailyConfigComponent.tsx Outdated Show resolved Hide resolved
src/components/DailyConfigComponent.tsx Outdated Show resolved Hide resolved
src/components/DailyConfigComponent.tsx Outdated Show resolved Hide resolved
const newTime = `${timePicker.getHours()}:${timePicker.getMinutes()}`;
await setConfig({ time: newTime });
await scheduleNextDailyRun({ tomorrow: true });
_setLocalConfig(getDailyConfig()); // force update, scheduleNextDailyRun runs saveDailyConfig
Copy link
Collaborator Author

@mdroidian mdroidian Oct 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem ideal but I'm not sure what a better method would be.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running into some type errors up the chain

adding Promise<DailyConfig> to scheduleNextDailyRun and getDailyConfig still left getExtensionApi().settings.set returning void, so left it as is

@mdroidian mdroidian merged commit f9420af into main Oct 23, 2023
1 of 2 checks passed
@mdroidian mdroidian deleted the daily-smartblock-component-update branch October 23, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants