Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove display name setting #122

Merged
merged 8 commits into from
Nov 19, 2024
Merged

Remove display name setting #122

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
af298f6
rm display name setting
mdroidian Oct 16, 2024
d247cae
doc fix
mdroidian Oct 16, 2024
6076f24
1.8.1
mdroidian Oct 16, 2024
15c7444
.
mdroidian Oct 16, 2024
611c589
rm display name setting
mdroidian Oct 16, 2024
0b2ae30
doc fix
mdroidian Oct 16, 2024
3b0ce3b
.
mdroidian Oct 16, 2024
45a9d47
Merge branch 'rm-display-name-setting' of https://github.com/RoamJS/s…
mdroidian Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/070-developer-docs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

SmartBlocks exposes a set of functions and objects for interacting with workflows. Roam developers can read from and write to these values from a `roam/js` block or as part of existing RoamJS extensions. This section includes technical notes for JavaScript developers working with SmartBlocks.

All methods below are attached to the `window.roamjs.extensions.smartblocks` object. Be careful before invoking any of them on load, as you will need to wait until the SmartBlocks extension is fully loaded.
All methods below are attached to the `window.roamjs.extension.smartblocks` object. Be careful before invoking any of them on load, as you will need to wait until the SmartBlocks extension is fully loaded.

## `registerCommand`

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "smartblocks",
"version": "1.8.0",
"version": "1.8.1",
"description": "Create custom and programmable templates from within Roam!",
"main": "./build/main.js",
"scripts": {
Expand Down
11 changes: 0 additions & 11 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ export default runExtension(async ({ extensionAPI }) => {
let isCustomOnly = extensionAPI.settings.get("custom-only") as boolean;
let hideButtonIcon = extensionAPI.settings.get("hide-button-icon") as boolean;
let highlighting = extensionAPI.settings.get("highlighting") as boolean;
const defaultDisplayName = getDisplayNameByUid(getCurrentUserUid());

extensionAPI.settings.panel.create({
tabTitle: "SmartBlocks",
Expand Down Expand Up @@ -245,16 +244,6 @@ export default runExtension(async ({ extensionAPI }) => {
description:
"Uses command highlighting to help write SmartBlock Workflows",
},
{
action: {
type: "input",
placeholder: defaultDisplayName,
},
id: "display-name",
name: "Display Name",
description:
"The display name that will appear in the store next to your workflow. By default, your display name in Roam will be shown. If not set, then your graph name will be shown.",
},
{
id: "daily",
name: "Daily",
Expand Down
Loading