Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: RoaringTreemap::select returns None if n >= len() #264

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

shekhirin
Copy link
Contributor

Copy link
Member

@Dr-Emann Dr-Emann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems uncontroversial.

Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@shekhirin
Copy link
Contributor Author

shekhirin commented Feb 13, 2024

@Kerollmops I believe there's some CI failure unrelated to this change

@Kerollmops
Copy link
Member

Kerollmops commented Feb 13, 2024

Hey @shekhirin 👋

Indeed. Can you push again? I cannot rerun the job via the Actions page, and it seems that the jobserver dependency is failing, and v0.1.28 has been released recently. That could help 🤷‍♂️

EDIT: It seems related to the MSRV. I'm bumping it to 1.66.

@shekhirin
Copy link
Contributor Author

will rebase on top of main once the MSRV bump is merged

@Kerollmops Kerollmops mentioned this pull request Feb 13, 2024
@Kerollmops
Copy link
Member

Can you rebase on main, please? 😃

@shekhirin
Copy link
Contributor Author

@Kerollmops done :)

@Kerollmops Kerollmops merged commit 87ab928 into RoaringBitmap:main Feb 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants