Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cookies behind flag (bare minimum) #56 #148

Closed
wants to merge 1 commit into from
Closed

Allow cookies behind flag (bare minimum) #56 #148

wants to merge 1 commit into from

Conversation

FabianSellmann
Copy link

@FabianSellmann FabianSellmann commented Jan 8, 2019 •
edited
Loading

Adds flag 'enableCookies' (default: false) which would allow to use cookies. #56

@FabianSellmann FabianSellmann changed the title bare minimum for #56 Allow cookies behind flag (bare minimum) #56 Jan 8, 2019
@FabianSellmann
Copy link
Author

Still need to add unit tests.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 96.154% when pulling 45b53a3 on FabianSellmann:master into 4814647 on Rob--W:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 96.154% when pulling 45b53a3 on FabianSellmann:master into 4814647 on Rob--W:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 96.154% when pulling 45b53a3 on FabianSellmann:master into 4814647 on Rob--W:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.8%) to 96.154% when pulling 45b53a3 on FabianSellmann:master into 4814647 on Rob--W:master.

@Rob--W
Copy link
Owner

Rob--W commented Jan 8, 2019

This implementation only rewrites the "path" component of a cookie, and the implementation is far from correct. It leaks cookies without path flag to every other proxied request, and lacks support for domain cookies (and implementing that is impossible). Moreover, the number of cookies per domain is limited, so any effort to implement persistent cookies is doomed for general use.

Thanks for your PR, but I'm going to close it for the above reasons.

@Rob--W Rob--W closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FabianSellmann @coveralls @Rob--W