Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): Add support for create_many to SQLite #1001

Merged
merged 18 commits into from
Aug 9, 2024

Conversation

AdeelK93
Copy link
Contributor

@AdeelK93 AdeelK93 commented Aug 8, 2024

Change Summary

  • Add support for create_many to SQLite #994
  • Now that every provider supports create_many, we do not need to distinguish between database providers
  • However, not every provider supports skip_duplicates, so this is now tracked in tests

Checklist

  • Unit tests for the changes exist
  • Tests pass without significant drop in coverage
  • Documentation reflects changes where applicable
  • Test snapshots have been updated if applicable

Agreement

By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

@AdeelK93 AdeelK93 changed the title Add support for create_many to SQLite feat(client): Add support for create_many to SQLite Aug 9, 2024
Copy link
Owner

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! Just minor nits :)

databases/utils.py Outdated Show resolved Hide resolved
databases/sync_tests/test_batch.py Outdated Show resolved Hide resolved
databases/tests/test_batch.py Outdated Show resolved Hide resolved
src/prisma/generator/templates/actions.py.jinja Outdated Show resolved Hide resolved
@AdeelK93 AdeelK93 requested a review from RobertCraigie August 9, 2024 16:17
@AdeelK93
Copy link
Contributor Author

AdeelK93 commented Aug 9, 2024

thanks @RobertCraigie, i've addressed your feedback. could you please re-run the tests? it’s the same transient error as last time breaking all the windows tests (incomplete read while downloading node binary)

@AdeelK93
Copy link
Contributor Author

AdeelK93 commented Aug 9, 2024

I'm confused, why are windows tests failing on this PR, but passing on my fork? 😕

@RobertCraigie
Copy link
Owner

I think it's just unlucky network issues :(

ile "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\http\client.py", line 626, in _safe_read

    chunk = self.fp.read(min(amt, MAXAMOUNT))

  File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\socket.py", line 704, in readinto

    return self._sock.recv_into(b)

  File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\ssl.py", line 1242, in recv_into

    return self.read(nbytes, buffer)

  File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\ssl.py", line 1100, in read

    return self._sslobj.read(len, buffer)

ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host

nodeenv installation failed; You may want to try installing `nodejs-bin` as it is more reliable.

Copy link
Owner

@RobertCraigie RobertCraigie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you!

docs/reference/operations.md Outdated Show resolved Hide resolved
@RobertCraigie RobertCraigie enabled auto-merge (squash) August 9, 2024 19:12
@RobertCraigie RobertCraigie merged commit 64e0ddc into RobertCraigie:main Aug 9, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants