-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client): Add support for create_many to SQLite #1001
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you! Just minor nits :)
thanks @RobertCraigie, i've addressed your feedback. could you please re-run the tests? it’s the same transient error as last time breaking all the windows tests (incomplete read while downloading node binary) |
I'm confused, why are windows tests failing on this PR, but passing on my fork? 😕 |
I think it's just unlucky network issues :(
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you!
Change Summary
create_many
, we do not need to distinguish between database providersskip_duplicates
, so this is now tracked in testsChecklist
Agreement
By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.