Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(engine): improve error message for missing binary #734

Merged
merged 2 commits into from
Mar 25, 2023

Conversation

RobertCraigie
Copy link
Owner

@RobertCraigie RobertCraigie commented Mar 25, 2023

Change Summary

The error message was misleading, they also might not be resolved because they could not be executed.

Checklist

  • Unit tests for the changes exist
  • Tests pass without significant drop in coverage
  • Documentation reflects changes where applicable
  • Test snapshots have been updated if applicable

Agreement

By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.

@RobertCraigie RobertCraigie changed the title feat(engine): improve error message for missing query engine binary feat(engine): improve error message for missing binary Mar 25, 2023
@RobertCraigie RobertCraigie merged commit eb3ff4d into main Mar 25, 2023
@RobertCraigie RobertCraigie deleted the improve-binary-missing-error branch March 25, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant