Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): fix partial types template to import enums #84

Merged
merged 2 commits into from
Oct 28, 2021
Merged

fix(generator): fix partial types template to import enums #84

merged 2 commits into from
Oct 28, 2021

Conversation

kafai-lam
Copy link
Contributor

@kafai-lam kafai-lam commented Oct 28, 2021

To correctly generate partial types, it should include the enums import in the jinjia template

@RobertCraigie RobertCraigie added bug/2-confirmed We have confirmed that this is a bug. kind/bug A reported bug. labels Oct 28, 2021
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #84 (ca72cc9) into main (04965e0) will increase coverage by 5.46%.
The diff coverage is 99.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   90.29%   95.76%   +5.46%     
==========================================
  Files          80       94      +14     
  Lines        3268     3805     +537     
  Branches      242      256      +14     
==========================================
+ Hits         2951     3644     +693     
+ Misses        286      120     -166     
- Partials       31       41      +10     
Impacted Files Coverage Δ
src/prisma/cli/commands/generate.py 94.28% <ø> (ø)
src/prisma/cli/commands/version.py 95.23% <ø> (-4.77%) ⬇️
src/prisma/errors.py 96.15% <ø> (-0.28%) ⬇️
src/prisma/http_abstract.py 92.59% <0.00%> (-0.63%) ⬇️
tests/integrations/sync/tests/conftest.py 100.00% <ø> (ø)
tests/integrations/sync/tests/test_basic.py 100.00% <ø> (ø)
tests/integrations/sync/tests/test_batch.py 100.00% <ø> (ø)
tests/test_cli/test_fetch.py 100.00% <ø> (ø)
tests/test_generation/test_partial_types.py 100.00% <ø> (ø)
tests/test_update.py 100.00% <ø> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 952e1e1...ca72cc9. Read the comment docs.

@RobertCraigie RobertCraigie merged commit b36d4f3 into RobertCraigie:main Oct 28, 2021
@RobertCraigie
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/2-confirmed We have confirmed that this is a bug. kind/bug A reported bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants