-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(requirements): set minimum pydantic version to 1.10.0 #882
Conversation
btw @RobertCraigie hi again! And thanks for the excellent work you're doing with this client, I love it! |
Thanks @ezorita! I appreciate it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is very slightly over-restrictive, just ran the tests with 1.10.0
and that also seems to work so I'd prefer to bump our minimum to that - thanks for fixing this!
(also sorry about the flaky test)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've lowered the version slightly myself as to not use up more of your time, thanks for bringing this to my attention and opening a PR!
my pleasure! |
Change Summary
Updated the minimum version of pydantic to
1.10.0
. Current version is set to1.8.0
but it lacks some required typing extensions.Reproduce
Run:
Output:
Checklist
Should not a a
Agreement
By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.