feat(client): add connect_or_create #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdeelK93
changed the title
There was a problem hiding this comment.
Thanks @AdeelK93!
r.e. testing, you should add tests to databases/tests/test_create.py and databases/sync_tests/test_create.py. See these docs for information on the database testing setup and let me know if you need any help, I don't think all the setup there is particularly well documented right now.
RobertCraigie
changed the title
AdeelK93
changed the title
|
thanks @RobertCraigie - I moved the tests to the files you mentioned, and renamed the function to snake case. Any other feedback? |
|
hi @RobertCraigie, looks like one test failed, but it’s a transient error (incomplete read while downloading node binary). the tests all passed on my fork, could we please retry? |
RobertCraigie
approved these changes
Aug 8, 2024
RobertCraigie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds connectOrCreate to support #754
Please let me know if I should make write tests (and where to put them). Thanks @RobertCraigie for your work on this great library!
Checklist
Agreement
By submitting this pull request, I confirm that you can use, modify, copy and redistribute this contribution, under the terms of your choice.