Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add eagerly_discard_variables flag for ReversibleSequence to be able … #8

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

lucidrains
Copy link
Contributor

…to save the output of the sequence and to retain the graph for the individual backward passes for the reversible blocks

…to save the output of the sequence and to retain the graph for the individual backward passes for the reversible blocks
@RobinBruegger
Copy link
Owner

@lucidrains I found a small Problem with your PR, you call ctx.multiple_backward but this member does not exist. I fixed it and created a new PR (#9). Could you please review if this matches with the changes you have in mind?

@RobinBruegger RobinBruegger merged commit e18cdc2 into RobinBruegger:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants