Skip to content

Commit

Permalink
Update method names: remove enableEventListeners/disableEventListeners
Browse files Browse the repository at this point in the history
You can use setOptions method to change the scroll/resize options at will to replicate the original functionality here, but I did not notice any reason to do this. The resize/scroll listeners appear to be getting added/removed upon toggling the tooltip without any workaround here.

https://popper.js.org/docs/v2/migration-guide/#8-update-method-names
  • Loading branch information
curtisbelt committed Mar 18, 2020
1 parent 296cc58 commit d51caa4
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions src/component/popper.js.vue
Original file line number Diff line number Diff line change
Expand Up @@ -159,15 +159,9 @@
watch: {
showPopper(value) {
if (value) {
this.$emit('show', this);
if (this.popperJS) {
this.popperJS.enableEventListeners();
}
this.updatePopper();
this.$emit('show', this);
} else {
if (this.popperJS) {
this.popperJS.disableEventListeners();
}
this.$emit('hide', this);
}
},
Expand Down

0 comments on commit d51caa4

Please sign in to comment.