Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSE #2238

Merged
merged 47 commits into from
Dec 9, 2024
Merged

SSE #2238

merged 47 commits into from
Dec 9, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Dec 4, 2024

This should be an alternative to zod-sockets and enable subscriptions without websockets, without socket.io and so on. Also related to #991

Resources

Findings

@RobinTail RobinTail added enhancement New feature or request miracle Mysterious events are happening here labels Dec 4, 2024
Copy link

coveralls-official bot commented Dec 4, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling bf6064c on try-sse
into 55162d7 on master.

@RobinTail
Copy link
Owner Author

there should be probably another entity like EventsFactory holding a dictionary of established events

@RobinTail RobinTail changed the title Exp: SSE SSE Dec 6, 2024
@RobinTail
Copy link
Owner Author

I consider the experiment a success

src/sse.ts Outdated Show resolved Hide resolved
This was referenced Dec 9, 2024
RobinTail added a commit that referenced this pull request Dec 9, 2024
Alternative to #2241 

This one should be better because it helps to avoid the situation when
you just forget to place `output` schema while using `.build()`. The
dedicated method. Not sure yet how to call it.
But it should be helpful for #2238
src/server.ts Outdated Show resolved Hide resolved
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready

@RobinTail RobinTail merged commit fdcc266 into master Dec 9, 2024
11 checks passed
@RobinTail RobinTail deleted the try-sse branch December 9, 2024 22:51
RobinTail added a commit that referenced this pull request Dec 10, 2024
Issue found while developing #2238 fixed in dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coverage Additional tests documentation Improvements or additions to documentation enhancement New feature or request external bug it's a bug, but in a dependency miracle Mysterious events are happening here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant