Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using bun #443

Merged
merged 58 commits into from
Jul 7, 2024
Merged

Using bun #443

merged 58 commits into from
Jul 7, 2024

Conversation

RobinTail
Copy link
Owner

No description provided.

@RobinTail RobinTail added dependencies Pull requests that update a dependency file CI/CD labels May 8, 2024
@RobinTail
Copy link
Owner Author

RobinTail commented May 8, 2024

Here is what I found out so far about bun:

  1. It is fast
  2. Benchmarking tool is not yet implemented: Implement a custom benchmark runner oven-sh/bun#6201
    a. Using bunx to run vitest bench and it stucks in CI for some reason.
    b. Fixed it by removing --bun from bunx, so it means that vitest relies on Node env for benching.
  3. Code coverage reports (lcov) are not yet implemented: Implement an lcov coverage reporter for bun test oven-sh/bun#4015

Copy link
Contributor

github-actions bot commented May 8, 2024

Performance benchmark

5e6ef1d

┌─────────────┬─────────┬─────────┬────────┬───────┐
│             │ 10      │ 100     │ 1000   │ 10000 │
├─────────────┼─────────┼─────────┼────────┼───────┤
│ Performance │ 6174710 │ 1094907 │ 127954 │ 15022 │
└─────────────┴─────────┴─────────┴────────┴───────┘

@RobinTail
Copy link
Owner Author

Another thing I found out about bun build:

error: Formats besides 'esm' are not implemented

No dedicated issue, only mentioned roadmap:
oven-sh/bun#159

@RobinTail
Copy link
Owner Author

And another issue - no DTS generation supported by bun build
oven-sh/bun#5141

@RobinTail
Copy link
Owner Author

RobinTail commented May 8, 2024

Another issue, link:./.. directive seems to be not handled correctly in package.json dependencies by bun.
Should use bun link I think

build.ts Outdated Show resolved Hide resolved
cjs.dts.json Outdated Show resolved Hide resolved
@RobinTail
Copy link
Owner Author

this somehow breaks dependency resolutions when running vitest

@RobinTail
Copy link
Owner Author

hanging vitest may be fixed in 2.0
vitest-dev/vitest#5047

@RobinTail
Copy link
Owner Author

Not fixed.
with --bun - hanging
without --bun can not find dependency

Repository owner deleted a comment from coveralls-official bot Jul 5, 2024
Repository owner deleted a comment from coveralls-official bot Jul 5, 2024
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling fa60065 on try-bun
into 6aeebf3 on master.

@RobinTail
Copy link
Owner Author

Repository owner deleted a comment from coveralls-official bot Jul 5, 2024
Copy link

coveralls-official bot commented Jul 7, 2024

Coverage Status

coverage: 100.0%. remained the same
when pulling ec61604 on try-bun
into 4994008 on master.

@RobinTail
Copy link
Owner Author

✅ QA passed

@RobinTail RobinTail merged commit 09285f3 into master Jul 7, 2024
14 checks passed
package.json Show resolved Hide resolved
RobinTail added a commit that referenced this pull request Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant