Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip comments on issues #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gudahtt
Copy link

@Gudahtt Gudahtt commented Aug 26, 2020

The bot is currently triggered for comments on both issues and pull requests, but the bot has no purpose on issues. If the job does end up getting run, it will fail with an error.

The example in the README has been updated to skip the job when triggered by issue comments. The runner will also bail early if it determines that it's being run for an issue comment rather than a pull request comment, instead of blowing up when it tries to get the pull request authors.

Fixes #10

@Gudahtt Gudahtt force-pushed the skip-issue-comments branch from c7a266f to e230267 Compare August 26, 2020 02:00
README.md Outdated Show resolved Hide resolved
@Gudahtt Gudahtt force-pushed the skip-issue-comments branch from 09975f4 to 463c844 Compare August 26, 2020 16:16
The bot is currently triggered for comments on both issues and pull
requests, but the bot has no purpose on issues. If the job does end
up getting run, it will fail with an error.

The example in the README has been updated to skip the job when
triggered by issue comments. The runner will also bail early if it
determines that it's being run for an issue comment rather than a pull
request comment, instead of blowing up when it tries to get the pull
request authors.

Fixes Roblox#10
@Gudahtt Gudahtt force-pushed the skip-issue-comments branch from 463c844 to c1c987f Compare August 26, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLA bot seems to be running against issue comments
1 participant