Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Run test in PRs #54

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix: Run test in PRs #54

merged 2 commits into from
Nov 30, 2023

Conversation

rgychiu
Copy link
Contributor

@rgychiu rgychiu commented Nov 20, 2023

Updates the test step to run in pull requests since the action needs to infer the PR number from context. Running the test step on the default branch will cause it to fail since it won't have a PR number.

Copy link

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@cliffchapmanrbx cliffchapmanrbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM

.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
Co-authored-by: cliffchapmanrbx <47404136+cliffchapmanrbx@users.noreply.github.com>
@rgychiu rgychiu merged commit 6345ea8 into master Nov 30, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants