This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 143
Remove the warning for setState on unmounted components #323
Merged
ZoteTheMighty
merged 11 commits into
Roblox:master
from
chriscerie:remove-setstate-warning
Oct 26, 2021
Merged
Remove the warning for setState on unmounted components #323
ZoteTheMighty
merged 11 commits into
Roblox:master
from
chriscerie:remove-setstate-warning
Oct 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matthargett
approved these changes
Oct 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, overall looks great. Thanks for bringing this upstream React improvement over!
matthargett
approved these changes
Oct 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent with upstream React, we should remove the error message when you
setState
on an unmounted component.In summary, while it can warn on potential memory leaks, false positives is common and can push people to undesirable workarounds:
For the full reasoning behind removing the warning, see Dan Abramov's PR: facebook/react#22114
Checklist before submitting:
CHANGELOG.md