Expose access to GetPropertyChangedSignal, take two #51
Conversation
lib/Change.lua
Outdated
| setmetatable(Change, { | ||
| __index = function(self, propertyName) | ||
| local changeListener = { | ||
| type = "propertyChange", |
There was a problem hiding this comment.
We should set the type to Change to line up with how Event works.
This also lines up really nicely with the other changes I want to make to typecheck arguments using the type value!
There was a problem hiding this comment.
Oops, I missed that part of the refactoring! Fixed now.
| return Reconciler |
There was a problem hiding this comment.
It looks like files' trailing newlines keep getting shuffled there and back, I feel like I should normalize those.
In the meantime, do you have an EditorConfig plugin enabled for your editor?
There was a problem hiding this comment.
I do, but sometimes it doesn't work (see all the times my commits sometimes get spaces instead of tabs).
There was a problem hiding this comment.
What editor do you use? The one for Sublime Text seems to horrifically break the automatic indentation detection. :(
There was a problem hiding this comment.
VS Code and this extension.
|
This should be ready to go now! |
|
Looks good to me! |
After a hideously botched rebase attempt followed by a history rewrite happened in #37, I fixed things!
Same API as #37, but now with: