-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codegen v2 #22
Merged
Merged
Codegen v2 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ported the codegen loop to operate on paths instead of names. It's a lot more gross because:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7.
This PR rewrites Tarmac's codegen pipeline from scratch to make it more composable and to get the project to baseline feature completion.
The new codegen module is more complicated. Instead of being templates that implement
fmt::Display
, they now all implement a method namedto_lua
that generates a minimal Lua AST. Using this AST, we can compose together different things that turn into Lua and format them in a sensible way. Early on in this PR I tried to keep thefmt
approach, but it became unworkable pretty quickly.There are a couple small foundational refactors tied up in this PR, as the branch has probably lived for too long. I'd love to get a basic checklist of things done on this code and then merge it as soon as we can.
TODO
AssetName